-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add MigrateHandler to allow reuse migrate genesis related function (backport #17296) #17301
Merged
julienrbrt
merged 3 commits into
release/v0.46.x
from
mergify/bp/release/v0.46.x/pr-17296
Aug 7, 2023
Merged
refactor: add MigrateHandler to allow reuse migrate genesis related function (backport #17296) #17301
julienrbrt
merged 3 commits into
release/v0.46.x
from
mergify/bp/release/v0.46.x/pr-17296
Aug 7, 2023
+78
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
approved these changes
Aug 7, 2023
mmsqe
reviewed
Aug 7, 2023
return errors.Wrap(err, "failed to JSON unmarshal initial genesis state") | ||
} | ||
|
||
migrationFunc := GetMigrationCallback(target) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@julienrbrt seems we need to use migrations or pass as cb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right!
julienrbrt
pushed a commit
that referenced
this pull request
Aug 7, 2023
julienrbrt
pushed a commit
that referenced
this pull request
Aug 7, 2023
… (#17303) Co-authored-by: mmsqe <mavis@crypto.com>
cmwaters
added a commit
to celestiaorg/cosmos-sdk
that referenced
this pull request
Aug 15, 2023
* build(deps): bump cometbft to v0.34.29 (cosmos#16553) * fix(x/auth): ensure nil .BaseAccounts are reported in ModuleAccount.Validate (backport cosmos#16554) (cosmos#16570) Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: snapshotter's failure is not propogated (backport cosmos#16588) (cosmos#16604) Co-authored-by: yihuang <huang@crypto.com> * feat: add custom max gas for block for sim config (backport cosmos#16656) (cosmos#16731) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix: accaddr cachefix (backport cosmos#15433) (cosmos#16823) Co-authored-by: KyleMoser <KyleMoser@users.noreply.github.com> Co-authored-by: HuangYi <huang@crypto.com> * fix(cli): improve `prune` command ux (backport cosmos#16856) (cosmos#16876) Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: query tx events with `>=` and `<=` operators (cosmos#16994) * docs: change bank multi-send command description (backport cosmos#16950) (cosmos#17019) * chore: prepare v0.46.14 (cosmos#16879) * refactor: add MigrateHandler to allow reuse migrate genesis related function (backport cosmos#17296) (cosmos#17301) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: resolve migration map in MigrateHandler (cosmos#17301) (cosmos#17302) * feat(x/gov): Emit VoterAddr (backport cosmos#17354) (cosmos#17357) Co-authored-by: Devon Bear <itsdevbear@berachain.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(x/gov): add MsgSubmitProposal SetMsgs method (backport cosmos#17387) (cosmos#17388) Co-authored-by: Julien Robert <julien@rbrt.fr> --------- Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com> Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: KyleMoser <KyleMoser@users.noreply.github.com> Co-authored-by: Rootul P <rootulp@gmail.com> Co-authored-by: Devon Bear <itsdevbear@berachain.com>
19 tasks
19 tasks
rootulp
pushed a commit
to rootulp/cosmos-sdk
that referenced
this pull request
Nov 7, 2023
…unction (backport cosmos#17296) (cosmos#17301) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
rootulp
pushed a commit
to rootulp/cosmos-sdk
that referenced
this pull request
Nov 7, 2023
rootulp
added a commit
to celestiaorg/cosmos-sdk
that referenced
this pull request
Nov 14, 2023
* refactor: add MigrateHandler to allow reuse migrate genesis related function (backport cosmos#17296) (cosmos#17301) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: resolve migration map in MigrateHandler (cosmos#17301) (cosmos#17302) * feat(x/gov): Emit VoterAddr (backport cosmos#17354) (cosmos#17357) Co-authored-by: Devon Bear <itsdevbear@berachain.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(x/gov): add MsgSubmitProposal SetMsgs method (backport cosmos#17387) (cosmos#17388) Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: use correct config key for db_backend (backport cosmos#17406) (cosmos#17412) Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: prepare v0.46.15 (cosmos#17408) * fix(x/authz): GetAuthorizations (backport cosmos#17334) (cosmos#17527) Co-authored-by: devon <80245700+devon-chain@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * docs: update x/group create-proposal to submit-proposal (backport cosmos#17544) (cosmos#17549) Co-authored-by: Félix C. Morency <1102868+fmorency@users.noreply.github.com> * fix: typo in comment (backport cosmos#17635) (cosmos#17638) Co-authored-by: Bryan White <bryanchriswhite@gmail.com> Co-authored-by: Marko <marbar3778@yahoo.com> * build(deps): bump cosmos/ledger-cosmos-go to v0.12.3 in v0.46 (backport cosmos#18105) (cosmos#18112) Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: prepare release notes v0.46.16 (cosmos#18118) * fix(server): don't hardcode grpc address to localhost (backport cosmos#18254) (cosmos#18260) Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: update tag date v0.46.16 (cosmos#18385) * revert: Go 1.19 * revert: c226e8b * chore(deps): upgrade to v1.29.0-tm-v0.34.29 * chore: downgrade to grpc 1.54.0 to match the versions used in upstream --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Devon Bear <itsdevbear@berachain.com> Co-authored-by: devon <80245700+devon-chain@users.noreply.github.com> Co-authored-by: Félix C. Morency <1102868+fmorency@users.noreply.github.com> Co-authored-by: Bryan White <bryanchriswhite@gmail.com> Co-authored-by: Marko <marbar3778@yahoo.com>
JeancarloBarrios
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Sep 28, 2024
…unction (backport cosmos#17296) (cosmos#17301) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
JeancarloBarrios
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #17296 done by Mergify.
Cherry-pick of 7a778f5 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com